5 files changed, 123 insertions, 89 deletions

diff --git a/mod/tinymce/views/default/input/longtext.php b/mod/tinymce/views/default/input/longtext.php
deleted file mode 100644
index daa68502e..000000000
--- a/mod/tinymce/views/default/input/longtext.php
+++ /dev/null
@@ -1,28 +0,0 @@
-<?php
-/**
- * Long text input with the tinymce text editor
- *
- * @package ElggTinyMCE
- *
- * @uses $vars['value']        The current value, if any
- * @uses $vars['js']           Any Javascript to enter into the input tag
- * @uses $vars['internalname'] The name of the input field
- * @uses $vars['internalid']   The id of the input field
- *
- */
-
-elgg_register_js('mod/tinymce/vendor/tinymce/jscripts/tiny_mce/tiny_mce.js', 'tinymce');
-
-// make sure the init script is only loaded once
-elgg_unextend_view('footer/analytics', 'tinymce/init');
-elgg_extend_view('footer/analytics', 'tinymce/init');
-
-?>
-
-<a class="elgg-longtext-control tinymce-toggle-editor small" href="javascript:toggleEditor('<?php echo $vars['internalname']; ?>');">
-	<?php echo elgg_echo('tinymce:remove'); ?>
-</a>
-
-<textarea class="elgg-input-textarea mceEditor" name="<?php echo $vars['internalname']; ?>" <?php if (isset($vars['internalid'])) echo "id=\"{$vars['internalid']}\""; ?> <?php echo $vars['js']; ?>>
-	<?php echo htmlspecialchars($vars['value'], null, 'UTF-8'); ?>
-</textarea>
diff --git a/mod/tinymce/views/default/js/tinymce.php b/mod/tinymce/views/default/js/tinymce.php
new file mode 100644
index 000000000..344d71b14
--- /dev/null
+++ b/mod/tinymce/views/default/js/tinymce.php
@@ -0,0 +1,102 @@
+elgg.provide('elgg.tinymce');
+
+/**
+ * Toggles the tinymce editor
+ *
+ * @param {Object} event
+ * @return void
+ */
+elgg.tinymce.toggleEditor = function(event) {
+	event.preventDefault();
+	
+	var target = $(this).attr('href');
+	var id = $(target).attr('id');
+	if (!tinyMCE.get(id)) {
+		tinyMCE.execCommand('mceAddControl', false, id);
+		$(this).html(elgg.echo('tinymce:remove'));
+	} else {
+		tinyMCE.execCommand('mceRemoveControl', false, id);
+		$(this).html(elgg.echo('tinymce:add'));
+	}
+}
+
+/**
+ * TinyMCE initialization script
+ *
+ * You can find configuration information here:
+ * http://tinymce.moxiecode.com/wiki.php/Configuration
+ */
+elgg.tinymce.init = function() {
+
+	$('.tinymce-toggle-editor').live('click', elgg.tinymce.toggleEditor);
+
+	$('.elgg-input-longtext').parents('form').submit(function() {
+		tinyMCE.triggerSave();
+	});
+
+	tinyMCE.init({
+		mode : "specific_textareas",
+		editor_selector : "elgg-input-longtext",
+		theme : "advanced",
+		language : "<?php echo tinymce_get_site_language(); ?>",
+		plugins : "lists,spellchecker,autosave,fullscreen,paste,inlinepopups",
+		relative_urls : false,
+		remove_script_host : false,
+		document_base_url : elgg.config.wwwroot,
+		theme_advanced_buttons1 : "bold,italic,underline,separator,strikethrough,bullist,numlist,undo,redo,link,unlink,image,blockquote,code,pastetext,pasteword,more,fullscreen",
+		theme_advanced_buttons2 : "",
+		theme_advanced_buttons3 : "",
+		theme_advanced_toolbar_location : "top",
+		theme_advanced_toolbar_align : "left",
+		theme_advanced_statusbar_location : "bottom",
+		theme_advanced_resizing : true,
+		theme_advanced_path : true,
+		width : "100%",
+		extended_valid_elements : "a[name|href|target|title|onclick],img[class|src|border=0|alt|title|hspace|vspace|width|height|align|onmouseover|onmouseout|name|style],hr[class|width|size|noshade],font[face|size|color|style],span[class|align|style]",
+		setup : function(ed) {
+			//show the number of words
+			ed.onLoadContent.add(function(ed, o) {
+				var strip = (tinyMCE.activeEditor.getContent()).replace(/(&lt;([^&gt;]+)&gt;)/ig,"");
+				var text = elgg.echo('tinymce:word_count') + strip.split(' ').length + ' ';
+				tinymce.DOM.setHTML(tinymce.DOM.get(tinyMCE.activeEditor.id + '_path_row'), text);
+			});
+
+			ed.onKeyUp.add(function(ed, e) {
+				var strip = (tinyMCE.activeEditor.getContent()).replace(/(&lt;([^&gt;]+)&gt;)/ig,"");
+				var text = elgg.echo('tinymce:word_count') + strip.split(' ').length + ' ';
+				tinymce.DOM.setHTML(tinymce.DOM.get(tinyMCE.activeEditor.id + '_path_row'), text);
+			});
+
+			ed.onInit.add(function(ed) {
+				// prevent Firefox from dragging/dropping files into editor
+				if (tinymce.isGecko) {
+					tinymce.dom.Event.add(ed.getBody().parentNode, "drop", function(e) {
+						if (e.dataTransfer.files.length > 0) {
+							e.preventDefault();
+						}
+					});
+				}
+			});
+
+		},
+		content_css: elgg.config.wwwroot + 'mod/tinymce/css/elgg_tinymce.css'
+	});
+
+	// work around for IE/TinyMCE bug where TinyMCE loses insert carot
+	if ($.browser.msie) {
+		$(".embed-control").live('hover', function() {
+			var classes = $(this).attr('class');
+			var embedClass = classes.split(/[, ]+/).pop();
+			var textAreaId = embedClass.substr(embedClass.indexOf('embed-control-') + "embed-control-".length);
+
+			if (window.tinyMCE) {
+				var editor = window.tinyMCE.get(textAreaId);
+				if (elgg.tinymce.bookmark == null) {
+					elgg.tinymce.bookmark = editor.selection.getBookmark(2);
+				}
+			}
+		});
+	}
+}
+
+elgg.register_hook_handler('init', 'system', elgg.tinymce.init);
diff --git a/mod/tinymce/views/default/tinymce/css.php b/mod/tinymce/views/default/tinymce/css.php
index 6980a67e0..b12cae82c 100644
--- a/mod/tinymce/views/default/tinymce/css.php
+++ b/mod/tinymce/views/default/tinymce/css.php
@@ -4,13 +4,18 @@
  *
  * Overrides on the default TinyMCE skin
  * Gives the textarea and buttons rounded corners
+ * 
+ * The rules are extra long in order to have enough
+ * weight to override the TinyMCE rules
  */
 ?>
 /* TinyMCE */
 .elgg-page .mceEditor table.mceLayout {
 	border: 1px solid #CCC;
+	
 	-webkit-border-radius: 5px;
 	-moz-border-radius: 5px;
+	border-radius: 5px;
 }
 .elgg-page table.mceLayout tr.mceFirst td.mceToolbar,
 .elgg-page table.mceLayout tr.mceLast td.mceStatusbar {
@@ -19,4 +24,8 @@
 .mceButton {
 	-webkit-border-radius: 4px; 
 	-moz-border-radius: 4px;
+	border-radius: 4px;
+}
+.mceLast .mceStatusbar {
+	padding-left: 5px;
 }
diff --git a/mod/tinymce/views/default/tinymce/embed_custom_insert_js.php b/mod/tinymce/views/default/tinymce/embed_custom_insert_js.php
index 84f98c405..a861a4035 100644
--- a/mod/tinymce/views/default/tinymce/embed_custom_insert_js.php
+++ b/mod/tinymce/views/default/tinymce/embed_custom_insert_js.php
@@ -1,8 +1,14 @@
 	if (window.tinyMCE) {
-		var editor = window.tinyMCE.get(textAreaName);
-		
+		var editor = window.tinyMCE.get(textAreaId);
+
 		if (editor) {
+
+			// work around for IE/TinyMCE bug where TinyMCE loses insert carot
+			if ($.browser.msie) {
+				editor.focus();
+				editor.selection.moveToBookmark(elgg.tinymce.bookmark);
+			}
+
 			editor.execCommand("mceInsertContent", true, content);
 		}
 	}
-	
\ No newline at end of file
diff --git a/mod/tinymce/views/default/tinymce/init.php b/mod/tinymce/views/default/tinymce/init.php
index 6282fa0f6..35dd71613 100644
--- a/mod/tinymce/views/default/tinymce/init.php
+++ b/mod/tinymce/views/default/tinymce/init.php
@@ -1,62 +1,7 @@
 <?php
 /**
- * TinyMCE initialization script
- *
- * You can find configuration information here:
- * http://tinymce.moxiecode.com/wiki.php/Configuration
+ * Initialize the TinyMCE script
  */
-?>
 
-<script type="text/javascript">
-tinyMCE.init({
-	mode : "specific_textareas",
-	editor_selector : "mceEditor",
-	theme : "advanced",
-	plugins : "spellchecker,autosave,fullscreen,paste",
-	relative_urls : false,
-	remove_script_host : false,
-	document_base_url : "<?php echo elgg_get_site_url(); ?>",
-	theme_advanced_buttons1 : "bold,italic,underline,separator,strikethrough,bullist,numlist,undo,redo,link,unlink,image,blockquote,code,pastetext,pasteword,more,fullscreen",
-	theme_advanced_buttons2 : "",
-	theme_advanced_buttons3 : "",
-	theme_advanced_toolbar_location : "top",
-	theme_advanced_toolbar_align : "left",
-	theme_advanced_statusbar_location : "bottom",
-	theme_advanced_resizing : true,
-	theme_advanced_path : true,
-	extended_valid_elements : "a[name|href|target|title|onclick],img[class|src|border=0|alt|title|hspace|vspace|width|height|align|onmouseover|onmouseout|name|style],hr[class|width|size|noshade],font[face|size|color|style],span[class|align|style]",
-	setup : function(ed) {
-		//show the number of words
-		ed.onLoadContent.add(function(ed, o) {
-			var strip = (tinyMCE.activeEditor.getContent()).replace(/(&lt;([^&gt;]+)&gt;)/ig,"");
-			var text = " <?php echo elgg_echo('tinymce:word_count'); ?>" + strip.split(' ').length + ' ';
-			tinymce.DOM.setHTML(tinymce.DOM.get(tinyMCE.activeEditor.id + '_path_row'), text);
-		});
-
-		ed.onKeyUp.add(function(ed, e) {
-			var strip = (tinyMCE.activeEditor.getContent()).replace(/(&lt;([^&gt;]+)&gt;)/ig,"");
-			var text = " <?php echo elgg_echo('tinymce:word_count'); ?>" + strip.split(' ').length + ' ';
-			tinymce.DOM.setHTML(tinymce.DOM.get(tinyMCE.activeEditor.id + '_path_row'), text);
-		});
-	},
-	content_css: '<?php echo elgg_get_site_url(); ?>mod/tinymce/tinymce_content.css'
-});
-
-function toggleEditor(id) {
-	if (!tinyMCE.get(id)) {
-		tinyMCE.execCommand('mceAddControl', false, id);
-		<?php $toggleEditor_linktext = elgg_echo('tinymce:remove'); ?>
-		$("a.tinymce-toggle-editor").html('<?php echo $toggleEditor_linktext ?>');
-	} else {
-		tinyMCE.execCommand('mceRemoveControl', false, id);
-		<?php $toggleEditor_linktext = elgg_echo('tinymce:add'); ?>
-		$("a.tinymce-toggle-editor").html('<?php echo $toggleEditor_linktext ?>');
-	}
-}
-
-$(document).ready(function() {
-	$('textarea').parents('form').submit(function() {
-		tinyMCE.triggerSave();
-	});
-});
-</script>
+elgg_load_js('tinymce');
+elgg_load_js('elgg.tinymce');
\ No newline at end of file