Puppet module for core cron functionality https://cgit.fluxo.info/puppet-cron_core/atom?h=main 2023-11-22T23:13:28+00:00 2023-11-22T23:13:28+00:00 Josh Cooper joshcooper@users.noreply.github.com 2023-11-22T18:54:32+00:00 urn:sha1:be5ae9bc9e198a00f2a790992b663dda374006ba The `filetype` provider executes `crontab` using Puppet's execution API, which returns ProcessOutput objects that inherit from String. See puppetlabs/puppet@732d450 The provider later uses String#gsub to strip off the HEADER. In Ruby 2.7, the gsub method returns a new instance of ProcessOutput: irb(main):002:0> Puppet::Util::Execution::ProcessOutput.new("# HEADER\n0 4 * * * /etc/init.d/script.sh\n", 0).gsub(/# HEADER/, '').class => Puppet::Util::Execution::ProcessOutput If you later serialize the crontab entries to YAML using `puppet resource`, then puppet warns about serializing unknown data types: # puppet resource cron --to_yaml Warning: Cron[unmanaged:/etc/init.d/script.sh-1]['command'] contains a Puppet::Util::Execution::ProcessOutput value. It will be converted to the String '/etc/init.d/script.sh' This wasn't an issue with Ruby 3.2, because String#gsub always returns a String: irb(main):002:0> Puppet::Util::Execution::ProcessOutput.new("# HEADER\n0 4 * * * /etc/init.d/script.sh\n", 0).gsub(/# HEADER/, '').class => String This commit explicitly converts the ProcessOutput to a String so the provider behaves consistently on all Ruby versions. Fixes #61 2018-12-08T01:55:20+00:00 Enis Inan enis.inan@puppet.com 2018-12-02T00:35:32+00:00 urn:sha1:e49408174d1e7662bd18f088accd8cc33d0e152c 2018-07-31T21:07:37+00:00 Jorie Tappa jorie@jorietappa.com 2018-07-31T19:56:46+00:00 urn:sha1:a2af7dd0b9713f279724d2c7e6f17bfd8ce2d95b