puppet-cron_core/spec/unit/provider, branch main

Convert ProcessOutput to String explicitly

2023-11-22T23:13:28+00:00

The `filetype` provider executes `crontab` using Puppet's execution API, which returns ProcessOutput objects that inherit from String. See puppetlabs/puppet@732d450 The provider later uses String#gsub to strip off the HEADER. In Ruby 2.7, the gsub method returns a new instance of ProcessOutput: irb(main):002:0> Puppet::Util::Execution::ProcessOutput.new("# HEADER\n0 4 * * * /etc/init.d/script.sh\n", 0).gsub(/# HEADER/, '').class => Puppet::Util::Execution::ProcessOutput If you later serialize the crontab entries to YAML using `puppet resource`, then puppet warns about serializing unknown data types: # puppet resource cron --to_yaml Warning: Cron[unmanaged:/etc/init.d/script.sh-1]['command'] contains a Puppet::Util::Execution::ProcessOutput value. It will be converted to the String '/etc/init.d/script.sh' This wasn't an issue with Ruby 3.2, because String#gsub always returns a String: irb(main):002:0> Puppet::Util::Execution::ProcessOutput.new("# HEADER\n0 4 * * * /etc/init.d/script.sh\n", 0).gsub(/# HEADER/, '').class => String This commit explicitly converts the ProcessOutput to a String so the provider behaves consistently on all Ruby versions. Fixes #61

(MODULES-11197) Update to pdk-templates 2.2.0

2021-10-01T11:57:09+00:00

Includes REFERENCE.md ToC fixes for MODULES-8183.

(maint) Switch to rspec-mocks

2021-03-11T12:37:19+00:00

(MODULES-8603) Ignore .keep_* files

2020-05-06T12:00:21+00:00

On Gentoo there's always a .keep_- (e.g., .keep_cronbase-0) file inside the cron directory to ensure it's not removed with rmdir. Since usernames are very unlikely to start with .keep_, we can safely filter out these hidden files.

(MODULES-8306) Port over the crontab filetypes from Puppet

2018-12-08T01:55:20+00:00

Update tests to pass on puppet 4

2018-11-28T20:05:41+00:00

(MODULES-8301) Update the unit tests with the crontab filetype fix

2018-11-27T09:02:52+00:00

Commit 420049f2 in Puppet fixed the crontab filetype's #read method to use Puppet::Util::Execution.execute instead of %x. This commit updates the unit tests to account for this change.

Fix Layout/CommentIndentation violation

2018-08-08T16:17:33+00:00

Fix RSpec/RepeatedExample violations

2018-08-01T16:27:33+00:00

Disable Security/YAMLLoad

2018-08-01T15:51:11+00:00