Puppet module for core cron functionality https://cgit.fluxo.info/puppet-cron_core/atom?h=main 2023-12-04T17:26:17+00:00 2023-12-04T17:26:17+00:00 Shubham Shinde shubham.shinde@perforce.com 2023-12-04T16:41:21+00:00 urn:sha1:c3805adc5d8155fc0193f35c547f08f181a71710 2023-11-22T23:13:28+00:00 Josh Cooper joshcooper@users.noreply.github.com 2023-11-22T18:54:32+00:00 urn:sha1:be5ae9bc9e198a00f2a790992b663dda374006ba The `filetype` provider executes `crontab` using Puppet's execution API, which returns ProcessOutput objects that inherit from String. See puppetlabs/puppet@732d450 The provider later uses String#gsub to strip off the HEADER. In Ruby 2.7, the gsub method returns a new instance of ProcessOutput: irb(main):002:0> Puppet::Util::Execution::ProcessOutput.new("# HEADER\n0 4 * * * /etc/init.d/script.sh\n", 0).gsub(/# HEADER/, '').class => Puppet::Util::Execution::ProcessOutput If you later serialize the crontab entries to YAML using `puppet resource`, then puppet warns about serializing unknown data types: # puppet resource cron --to_yaml Warning: Cron[unmanaged:/etc/init.d/script.sh-1]['command'] contains a Puppet::Util::Execution::ProcessOutput value. It will be converted to the String '/etc/init.d/script.sh' This wasn't an issue with Ruby 3.2, because String#gsub always returns a String: irb(main):002:0> Puppet::Util::Execution::ProcessOutput.new("# HEADER\n0 4 * * * /etc/init.d/script.sh\n", 0).gsub(/# HEADER/, '').class => String This commit explicitly converts the ProcessOutput to a String so the provider behaves consistently on all Ruby versions. Fixes #61 2023-02-17T17:22:29+00:00 Michael Hashizume michael.hashizume@puppet.com 2023-02-17T17:22:29+00:00 urn:sha1:694fd4d6d92c868e3ec52b021961e43b04903db1 Legacy facts are removed in Puppet 8. This commit updates a spec file from using legacy facts to using structured facts. 2023-02-14T22:41:13+00:00 Michael Hashizume michael.hashizume@puppet.com 2023-02-14T22:41:13+00:00 urn:sha1:3e48a3c78b00cc619020c97445525aaaca616f01 In acb57af, we updated the module according to PDK template 7.2.1, which updated puppetlabs_spec_helper. The updated version of puppetlabs_spec_helper removed the Beaker rake task, which we use for acceptance testing. This commit adds the voxpupuli-acceptance gem, which re-adds the Beaker rake task. 2023-02-10T18:45:29+00:00 Michael Hashizume michael.hashizume@puppet.com 2023-02-10T18:45:29+00:00 urn:sha1:cf562a8bda5df98b91fea01a43e128a8e821058c This commit addresses the Rubocop Style/RedundantBegin cop and removes an explicit `begin` block in favor of implicit syntax. 2021-10-01T11:57:09+00:00 Gabriel Nagy gabriel.nagy@puppet.com 2021-10-01T11:57:09+00:00 urn:sha1:dd42efd5323314047d2c44e02f2f7e3472954697 Includes REFERENCE.md ToC fixes for MODULES-8183. 2021-08-17T16:46:58+00:00 Josh Cooper joshcooper@users.noreply.github.com 2021-08-17T16:46:58+00:00 urn:sha1:54db10d91bb5da04f8f4fb9d66138aba9e5e38a4 Took the safest route and disabled cops either globally in .rubocop.yml for just for specific cases in lib/ 2021-08-17T16:18:57+00:00 Josh Cooper joshcooper@users.noreply.github.com 2021-08-17T16:18:57+00:00 urn:sha1:a3dcc2e0070e6223342a5ce72f9003fd12c1eab9 Generated using: $ pdk --version 2.2.0 $ pdk update --template-ref 2.2.0 2021-03-11T12:37:19+00:00 Gabriel Nagy gabriel.nagy@puppet.com 2021-03-11T12:17:09+00:00 urn:sha1:51ebf2d8d5c02c7cd314edd9e6507163a8073785 2020-08-10T12:44:35+00:00 Dorin Pleava dorin.pleava@puppet.com 2020-08-06T12:14:37+00:00 urn:sha1:29925fb28a09075ea4c4105674dca2415e1c7800 When applying a cron manigest that contains leading zeroes in a periodic attribute (hour, minute, month, monthday, weekday), puppet will strip down the zeroes even if they are accepted by the system cron. Now puppet will only convert to integer the periodic attributes when validating them, but will not change the input from the manifest.