| Age | Commit message (Collapse) | Author |
|---|
|
Previously, when running with beaker 5 and latest beaker-puppet, tests failed
with:
cannot add defaults of type pe for host redhat7-64-1 (add_pe_defaults_on not present)
The error came from beaker-puppet when it tried to configure the host as a PE
agent[1].
The root cause is beaker defaults its options to `pe`[2]. When `beaker-puppet`
calls the `configure_type_defaults_on` method, it calls the appropriate
`add_<type>_defaults_on` method. This works when using beaker 4 as `beaker-pe`
is pulled in as a dependency and its `add_pe_defaults_on` method[3] is included
into the tests.
However, when running with beaker5, beaker-pe is not loaded, so the method is
undefined. It appears beaker-puppet_install_helper is responsible for the
whether beaker-pe is loaded or not, but only when using
beaker-puppet_install_helper 0.9.4.
Since these tests don't actually depend on PE, drop beaker-pe, require
'beaker-puppet' directly (so the install_from_build_data_url method exists) and
configure the host type directly.
[1] https://github.com/puppetlabs/beaker-puppet/blob/7175b5c1acb5cddb3a31ddcc114f09cddd3b83d0/lib/beaker-puppet/install_utils/puppet_utils.rb#L167
[2] https://github.com/voxpupuli/beaker/blob/c61ee381d3801bad70989d9b3cbf970771e6f330/lib/beaker/options/presets.rb#L139
[3] https://github.com/puppetlabs/beaker-pe/blob/3bfe913b8d57c805cc0c51ae899fff174224d5f5/lib/beaker-pe/install/pe_defaults.rb#L93
|
|
This commit updates this module from PDK template 2.7.1 to 3.0.1 and updates
the module release workflows to use the newer release_prep instead of
auto_release GitHub Action wofklow. This commit also:
- Removes the github_changelog_generator and concurrent-ruby gems because they
are no longer needed for the new module release process in PDK template
- Updates the Rakefile to use Vox Rake tasks only if the vospupuli-acceptance
gem is installed
|
|
Previously in Beaker, you could use a standalone stdout method to
access output from remote machines.
This was deprecated in 2013 with voxpupuli/beaker@28b2510 and dropped
entirely in voxpupuli/beaker@73a31c7.
This commit replaces stdout in favor of calling stdout on Result
objects.
|
|
The assert_no_match method in Beaker was long deprecated then eventually
removed altogether in voxpupuli/beaker@6282311
This commit updates assert_no_match to refute_match.
|
|
In e4337c0, we updated the module according to PDK template 2.7.4,
which updated puppetlabs_spec_helper. The updated version of
puppetlabs_spec_helper removed the Beaker rake task, which we use
for acceptance testing.
This commit adds the voxpupuli-acceptance gem, which re-adds the
Beaker rake task.
|
|
Includes REFERENCE.md ToC fixes for MODULES-8183.
|
|
|
|
regular expression that we use to separate values by comma was updated
to take into account only commas outside quoted strings
|
|
|
|
|
|
`hosts_as` takes a role type, not an array of hosts. Unfortunately,
`install_module_on` only takes one host as an argument. We were lucky
that `hosts_as('default')` was returning only one host, but we should be
explicitly installing this on each host individually.
|
|
Prior to this commit, the acceptance tests for mailalias were broken up
in a way that was not logical. The tests had been broken up simply
following the 'steps' from the previous iteration. This new structure
did not work, since later steps were dependent on earlier steps. The
tests could not be run in isolation. This commit changes the test set up
so that we can more easily run tests in isolation and in random order.
|
|
|
|
|
|
Certain files, like the Gemfile and spec/spec_helper.rb are managed by
PDK. When we run `pdk update`, any changes we make to these files will
be overwritten.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
